Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
…ase tests Key fixes: - Editor tests: Use createDocumentPageAndNavigate instead of "Getting started" page to avoid strict mode violations from template content - Paste tests: Replace fragile hover-dependent inline-add-page with shared helper - Toolbar: Add data-testid to BulletedList, NumberedList, Quote toolbar buttons - CI config: Add trailing slash to database/ path to prevent prefix-matching - Platform-aware: Use Meta+A on Mac, Control+A on Linux for select-all - Skip version-history tests (require dev-mode window.__TEST_DOC__ globals) - Various selector and timing fixes for database and page tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Auth: Remove response.json() call that races with body GC - Image: Use same dialog expand pattern as createDocumentPageAndNavigate Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Toolbar: Use Home+Shift+End instead of Meta+A to avoid cross-block selection (cross-block hides list/quote buttons in toolbar) - Toolbar: Use .last() for MuiPopover-root to handle Quick Notes popover - Markdown shortcuts: Use BlockSelectors.blockByType for heading assertions - Slash menu: Use data-testid instead of getByText for menu items (avoids "Heading 1" vs "Toggle Heading 1" ambiguity) - Cursor tests: Use Home/End instead of selectAll+Arrow for line navigation - Inline code: Use specific span.bg-border-primary selector Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add data-testid attributes to CustomToolbar.tsx (calendar-toolbar, calendar-title, calendar-prev/next/today-button) - Add data-testid to EventPopoverContent.tsx delete button - Update CalendarSelectors to use data-testids instead of .fc classes - Fix share/publish strict mode violations by scoping getByText to share popover (avoids matching multiple elements) - Fix move-page-restrictions to use ViewActionSelectors.popover and moveToButton testids instead of data-slot selector - Fix paste-code blockquote assertion to check text content only - Fix calendar-edit-operations createEventOnCell to use dblclick and contenteditable selector - Fix embedded create-delete to use controls-menu testid - Fix editor callout to use slash-menu-callout testid - Fix editor navigate to use BlockSelectors - Add src/** to build cache key to ensure source changes rebuild - Skip calendar layout test (non-existent UI elements) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- database-view-tabs: increase tab appearance timeout to 5s
- database-view-consistency: fix calendar event creation (dblclick + contenteditable)
- filter-date: increase wait times after filter deletion
- person-cell-publish: scope getByText('Publish') to share popover
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Paste tests: fix strict mode violations with .first()/.last(), relax formatting assertions that depend on markdown rendering - Calendar reschedule: rewrite to use correct UI interactions (DateTime cell click + DateTimeCellPicker + clear-date-button) - Calendar event creation: use single click instead of dblclick, add assertions for popover visibility - Database view tabs/consistency: fix addView dropdown menu interaction to use data-slot selector for DropdownMenuContent - Filter tests: increase wait times, fix selectExistingOption to use select-option-menu testid scope - Source: add data-testid to clear-date-button and no-date-row Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
appflowy
force-pushed
the
use_playwright
branch
from
15b5bb8 to
5570c2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
General
Testing
Feature-Specific