Skip to content

fix: prevent browser auto-translate from crashing React DOM#283

Merged
appflowy merged 1 commit intomainfrom
disable_translate
Mar 15, 2026
Merged

fix: prevent browser auto-translate from crashing React DOM#283
appflowy merged 1 commit intomainfrom
disable_translate

Conversation

@appflowy
Copy link
Contributor

@appflowy appflowy commented Mar 15, 2026

Description


Checklist

General

  • I've included relevant documentation or comments for the changes introduced.
  • I've tested the changes in multiple environments (e.g., different browsers, operating systems).

Testing

  • I've added or updated tests to validate the changes introduced for AppFlowy Web.

Feature-Specific

  • For feature additions, I've added a preview (video, screenshot, or demo) in the "Feature Preview" section.
  • I've verified that this feature integrates seamlessly with existing functionality.

Summary by Sourcery

Bug Fixes:

  • Disable automatic browser and Google translation on the main HTML document to avoid crashes or instability in the React DOM rendering.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 15, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Disables browser auto-translation (especially Google Translate) for the main HTML document to prevent translation-induced React DOM crashes by adding appropriate attributes and meta tags.

Sequence diagram for browser auto-translate vs React DOM after fix

sequenceDiagram
    actor User
    participant Browser
    participant GoogleTranslate
    participant ReactApp

    User->>Browser: Open AppFlowy Web page
    Browser->>ReactApp: Load index.html
    ReactApp-->>Browser: Render React DOM

    alt With_auto_translate_disabled
        Browser->>Browser: Detect translate=no attribute
        Browser->>Browser: Read meta google=notranslate
        Browser--xGoogleTranslate: Block automatic translation
        ReactApp-->>User: UI remains stable
    else Without_auto_translate_disabled
        Browser->>GoogleTranslate: Allow automatic translation
        GoogleTranslate-->>Browser: Modify DOM text nodes
        Browser->>ReactApp: Inject translated content
        ReactApp-->>Browser: Virtual DOM mismatches real DOM
        Browser-->>User: Potential React DOM crash or errors
    end
Loading

File-Level Changes

Change Details Files
Disable automatic browser translation of the app shell to avoid React DOM crashes caused by mutated DOM.
  • Add translate="no" attribute to the root element to signal that the document should not be translated.
  • Add a tag in the to explicitly disable Google automatic translation.
index.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider whether disabling translation at the <html> level is too broad for your use case; if some parts of the app should remain translatable, you may want to scope translate="no" to specific containers instead.
  • Since this change targets Google’s auto-translate specifically, evaluate whether similar meta or attributes are needed for other major translation providers if cross-browser behavior is important.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider whether disabling translation at the `<html>` level is too broad for your use case; if some parts of the app should remain translatable, you may want to scope `translate="no"` to specific containers instead.
- Since this change targets Google’s auto-translate specifically, evaluate whether similar meta or attributes are needed for other major translation providers if cross-browser behavior is important.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@appflowy appflowy merged commit 8099d05 into main Mar 15, 2026
12 of 14 checks passed
@appflowy appflowy deleted the disable_translate branch March 15, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant