fix: Windows encoding crash in HelixVisualizer.render()#28
Merged
Conversation
render() now reconfigures stdout to UTF-8 and falls back to buffer.write(utf-8 bytes) when sys.stdout.write() raises UnicodeEncodeError on Windows cp1252. Also: clean up lint warnings across all test files (unused imports, unused variables, lambda-to-def). Bump to v0.2.1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
io.UnsupportedOperation (subclass of OSError) can occur on some redirected/piped stdout. Catch alongside AttributeError. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
Code Review — ApproveFixed: reconfigure guard now catches OSError (covers io.UnsupportedOperation on redirected streams) alongside AttributeError. 824 tests passing, ruff clean. LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
UnicodeEncodeErrorwhenHelixVisualizer.render()writes Unicode block characters on Windows (cp1252 default encoding).Fix
render()callssys.stdout.reconfigure(encoding='utf-8')before writingsys.stdout.buffer.write(output.encode('utf-8'))ifUnicodeEncodeErrorstill occursAlso
Test plan
ruff check src/ tests/clean