Repository navigation
Make Switch site go round the favourites instead of between the two most recent sites (#100) - #118
Merged
Merged
Conversation
…ost recent sites (#100) Issue #75 asked for a way between two sites, and the switch walked the history for it: the first entry not on this site. That is why the reporter's third site never came up — the two most recent sites trade places for ever. The switch now goes round the favourites in tile order, each at the last page seen on that site, and falls back to the old walk when there is no round to go. The site-rules harness holds both. Also records the reopened #100 in INTERNALS: the page sent does not carry the freeze (the report keeps one launch back, and that launch had TikTok open for seconds without a video), and where the hold is not — a page that has not finished loading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #100's reporter, reopening it: Switch site "only switches between 2 sites instagram and spotify not to 3rd favourite tiktok".
That is the switch doing what #75 asked — a way between two sites — by walking the history: the first entry not on this site is the site just left, so the two most recent sites alternate for ever and a third never comes up. The switch now goes round the favourites in the order their tiles sit on the start screen, each stop opening the last page the history has on that site (the tile's address only for a site never visited), and falls back to the old walk when there is no round to go (no favourites, or every favourite on the site already open). From the start screen it still opens the most recent site.
SiteRules.OtherSitegains the favourites-first form; the history walk stays as the fallback. One caller (NuiBrowserApp.SwitchSite).tools/siterules/run.shholds the round: tile order, wrap, two tiles on one site as one stop, the last page rather than the tile, a never-visited favourite at its tile, a site with no favourite going to the first, the fallbacks, a generated page not a stop. All 79 checks pass.load finished), and notes where the hold is not — a page that has not finished loading — without building on it../build.sh allbuilds all five packages.