Add member categorization#238
Conversation
|
Code Review — fleet-rev OverallThe PR adds an optional Correctness1. Whitespace-only category silently stored ( updates.category = input.category || undefined;
updates.category = input.category.trim() || undefined;2. Fragile index-based join in const rowsWithCategory = rows.map((r, i) => ({ ...r, category: agents[i].category ?? null }));Relies on 3. Multi-line statusline — new code joins category groups with Edge Cases4. Category ordering is insertion-order (no sort). Users might expect alphabetical. Consider sorting Map keys, or at minimum putting SecurityNo issues. TestsNone added. Missing at minimum: whitespace-clearing behaviour on update, grouped output format in Code Quality5. Duplicated group-by-category logic across function groupByCategory<T>(items: T[], getCategory: (item: T) => string): Map<string, T[]>6. Unrelated Summary
|
Resolves conflict in check-status.ts: kept category grouping from feature branch and log= display from main. Category also attached to AgentStatusRow at build time (not retroactively by index) as part of conflict resolution.
…e restore - Add groupByCategory<T> helper to agent-helpers.ts; refactor check-status, list-members, and statusline to use it (eliminates duplicated group-and-sort logic) - Add 13 tests: whitespace-clear on update, category grouping in fleet_status and list_members (compact + JSON), uncategorized placement, whitespace handling - Restore package.json and package-lock.json from main (reverts unrelated version downgrade and peer:true additions introduced by merge base mismatch) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keep both lastLlmActivityAt (stall detector, re-added in main) and category (this PR) in the Agent interface. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* docs: revise roadmap -- promote SSE/dashboard/docker to near-term, A2A to medium-term, remove Codex/Copilot, fix encoding * docs: remove Cursor/Windsurf integration guide from roadmap * docs: improve session log export roadmap item * docs: fold cost dashboard into web dashboard item * docs: add memory plane integration to near-term, move expanded targets to medium-term * docs: demote member groups/tags to bottom of medium-term * docs: adjust timeframes, promote Fleet-as-a-Service and multi-fleet-federation to top of long-term * docs: revise roadmap based on discussions analysis -- add playbooks, PM lifecycle, extension layer, discussion links, fix misrepresentations * docs: remove result aggregation, link member groups/tags to PR #238 * docs: move member groups/tags to near-term (PR already open) * docs: link open PRs and issues into roadmap, add multiple providers and Slack notifications * docs: add DeepWiki codebase wiki link to README and FAQ * chore: remove docs/site folder --------- Co-authored-by: Bot <bot@apra-fleet.dev>
1. Core Data Model Updates
assigned to a logical group (e.g., "production", "testing", "gpu-nodes").
the upstream repository, ensuring no loss of functionality from either feature.
2. Member Management Enhancements
are added to the fleet.
fleet.
3. Smart Status Rendering (check_status)
navigate by separating different types of workers.
worker-1(idle)).
simultaneously shows your custom groups and alerts you if a new version of apra-fleet is available.
4. Infrastructure & Sync
hardening, and performance improvements.
types.
Technical Impact: These changes improve the scalability of the fleet CLI by allowing users to organize and monitor large numbers
of members through logical grouping, without breaking compatibility with new upstream security and automation features.