feat(cli): --version, --help, and strict empty-string validation (e2e-s1.2)#17
Open
kumaakh wants to merge 3 commits into
Open
feat(cli): --version, --help, and strict empty-string validation (e2e-s1.2)#17kumaakh wants to merge 3 commits into
kumaakh wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sprint
e2e-s1.2-25826536670implements 3 P1 issues from.beads/issues.jsonl(labele2e-testing):--version/-vflag that printsfleet-e2e-toy v1.0.0and exits 0 without starting the HTTP server.--help/-hflag andhelpsubcommand that print usage info and exit 0 without starting the HTTP server.titleandcontentwith a 400 and a clear message. Unit + integration tests added.CLI handling runs at the very top of
src/index.tsso the Express app does not start when only info-flags are requested.Test plan
npm run lint— cleannpm test— 33/33 passing (12 new tests vs main's 21)npm run build— clean tsc emitnode dist/index.js --version→fleet-e2e-toy v1.0.0, exit 0node dist/index.js --help→ usage listing, exit 0/api/noteswith empty or whitespacetitle/contentreturns 400Review
Reviewer verdict (committed in feedback.md before cleanup): APPROVED, 0 HIGH findings.