fix(gui): render bolt pairing click icons - #1144
Augustine-C wants to merge 1 commit into
Conversation
|
678e3d5 to
ef2d946
Compare
|
Second reproduction, plus a workaround for anyone landing here before this merges. Hit this on v0.8.2 (macOS 26.6.2, arm64) pairing an MX Master 4 to a Bolt receiver: the Add Device window showed the instruction line and the bare Workaround without a patched build — the agent traces the passkey notification, so: The request then lands in Decode exactly as Would be good to get this merged; it makes Bolt mouse pairing unusable from the GUI alone. Related, same code path: #412. |
|
OK how the heck do I convert this? I can see the log entry e.g. |
ef2d946 to
116d6a7
Compare
The passkey step glyphs painted nothing because the svg elements set no text color, leaving only the step numbers 1-10 above no indication of which button to click. GPUI only paints an svg when a text color is set; give the icons the palette's primary text color like every other svg in the crate.
116d6a7 to
ef02921
Compare
Summary
The Bolt pointer-passkey step list showed only the step numbers 1-10, with no indication of which button to click: the per-step click glyphs never painted because their
svg()elements set no text color, and GPUI only paints an SVG when one is set.Changes
openlogi-desktop: give the passkey click icons.text_color(pal.text_primary)inpasskey_panel, matching every othersvg()call site in the crate (app/home.rs,features/action_ring.rs,features/keyboard/function_row.rs).Testing
cargo fmt -p openlogi-desktop -- --checkcargo check -p openlogi-desktopcargo clippy -p openlogi-desktop --all-targets -- -D warningscargo test -p openlogi-desktop(200 passed)Runtime-verified on hardware: paired an MX Anywhere 3S over Bolt and confirmed the left/right click glyphs now render above the 1-10 numbers.
Fixes #1221