Conversation
|
zmingxie
force-pushed
the
fix/track-locale-catalogs-as-build-inputs
branch
from
September 15, 2026 22:30
1fe1774 to
557fa77
Compare
zmingxie
force-pushed
the
fix/track-locale-catalogs-as-build-inputs
branch
from
September 17, 2026 16:13
557fa77 to
6e0d38b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust_i18n::i18n!("../openlogi-ui/locales", …)reads the catalogs at macro-expansion time, and Cargo does not track a proc macro's file reads. No build script declared them as inputs, so editing a translation did not rebuild the binaries that embed it — the stale catalog stayed compiled in until something unrelated recompiled the crate.the_shared_catalog_is_wired_upin the overlay and agent, which.claude/rules/i18n.mdnames as the check that a catalog is wired up, can pass against a stale catalog. So that gate is not currently load-bearing.Changes
openlogi-desktop,openlogi-agent,openlogi-overlay— eachbuild.rsnow emitscargo:rerun-if-changed=../openlogi-ui/locales. In the agent and overlay the directive has to precede the non-Windows early return, or it is never emitted on the platforms that actually build those binaries.Testing
Before, on
b6634915:No recompile, so the embedded catalog kept the old strings. After this change the same sequence gives:
Compiling openlogi-desktop v0.8.3 (/Users/mxie/dev/OpenLogi/crates/openlogi-desktop)Verified the same way for
openlogi-overlayandopenlogi-agent— both of which need the pre-guard placement to work off Windows.Found while building a locale change for #1116:
cargo xtask ciwas green and the bundle built, yet the GUI binary still contained the pre-edit string.cargo xtask cion macOS/aarch64: 9 passed, 0 failed. Not run on this host and not claimed green —shell(needs shellcheck/shfmt),tests (linux)(Linux-only),cargo-deny(not installed; no dependency change here).