fix(gui): recognize MX Ergo's DPI slot name for the mouse diagram - #1391
Open
armandodollia wants to merge 6 commits into
Open
armandodollia wants to merge 6 commits into
armandodollia wants to merge 6 commits into
Conversation
Logitech's asset metadata names the MX Ergo family's precision-mode/DPI button SLOT_NAME_CHANGE_POINTER_SPEED rather than the SLOT_NAME_DPI_BUTTON / SLOT_NAME_MODESHIFT_BUTTON names other mice use, so the hotspot was silently dropped and the button never appeared as remappable. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Changes
openlogi-desktop:map_slot_name()incrates/openlogi-desktop/src/features/mouse/geometry.rsnow also recognizesSLOT_NAME_CHANGE_POINTER_SPEED— the slot name Logitech's own asset metadata uses for the MX Ergo family's DPI/precision-mode button (confirmed against the cachedmx_ergo_smetadata), alongside the existingSLOT_NAME_MODESHIFT_BUTTON/SLOT_NAME_DPI_BUTTONnames. Added a test case for the new alias.Testing
cargo test -p openlogi-desktop features::mouse::geometry::— pass (including newdpi_slot_names_map_to_dpi_toggle_buttoncase)cargo test -p openlogi-desktop— 213 passedcargo fmt --all -- --check— passcargo clippy -p openlogi-desktop --all-targets -- -D warnings— passcargo run -p openlogi-desktop) against a physical MX Ergo S over Bluetooth — the DPI Toggle button now shows up as a hotspot in the Buttons panel and is bindable (screenshot below).🤖 Generated with Claude Code
p.s. Used Claude to find where the issue was because I am not as familiar with the codebase then spend some time working backwards and checking all the logs from the main branch ap and the code changes it made and deemed the change to be safe with a small blast radius