Conversation
…ut mirror build_virtual_device() left the re-injecting uinput device on evdev's default sample ID (bus USB, vendor 0x1234, product 0x5678) instead of the grabbed mouse's own. libinput and desktop environments key per-device settings — pointer acceleration profile, remembered pointer speed — off the reported vendor/product ID, so every re-injected Logitech mouse looked identical and unrecognized, silently falling back to default acceleration instead of what the user configured for that hardware. Fixes AprilNEA#1075
|
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uinputvirtual device.build_virtual_device()never set that virtual device'sinput_id, so it keptevdev's default sample ID (bus USB, vendor0x1234, product0x5678) instead of the real hardware's.Changes
crates/openlogi-hook:build_virtual_device()now copiesdevice.input_id()(bus type, vendor, product, version) onto theVirtualDeviceBuilderinstead of leaving it at the uinput default.Testing
cargo fmt --all -- --checkcargo clippy -p openlogi-hook -p openlogi-agent -p openlogi-agent-core -p openlogi-desktop -p openlogi-overlay --all-targets -- -D warningscargo test -p openlogi-hook -p openlogi-agent -p openlogi-agent-core -p openlogi-desktop -p openlogi-overlayudevadm info/libinput list-deviceson/dev/input/eventNfor "OpenLogi virtual mouse" reports the same vendor/product as the physical device, then compare pointer speed with a per-device system sensitivity setting applied.Fixes #1075