Conversation
The receiver-identity registry had no entry for USB product ID 0xc534, the Nano receiver bundled with budget wireless combos such as the MK270 and MK295, so OpenLogi never enumerated it or the paired keyboard/mouse. Cross-checked against Solaar's NANO_RECEIVER_C534 as the established reference implementation, alongside the neighboring 0xc537 Nano receiver already registered here. Fixes AprilNEA#866
|
receiver_identities_are_unique only proves no duplicate identity was introduced; it says nothing about whether 0xc534 resolves to the right brand and protocol. Adds a focused regression test alongside the existing one for the c54d receiver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/openlogi-device-registry/src/receiver.rs'sRECEIVERStable had no entry for USB product ID0xc534— the Nano receiver bundled with budget wireless combos such as the MK270 and MK295 — so OpenLogi never enumerated the receiver or the paired keyboard/mouse at all.NANO_RECEIVER_C534as an established reference implementation (same nano-receiver family already covered here by the neighboring0xc537entry from feat(hid): support G602 nano receiver #684).openlogi-device-registry::receiver::RECEIVERSis the single source of truth other lookups (find_receiver,crates/openlogi-core/src/hid/route.rs) already consume, so this one-line addition is sufficient — no other list needed updating.Changes
crates/openlogi-device-registry: register046d:c534as aNano-brand,Unifying-protocol receiver.Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceRUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --document-private-items --exclude openlogi-ui --exclude openlogi-desktop --exclude openlogi-overlay --exclude openlogi-agentopenlogi list/Device Manager output (hardware IDVID_046D&PID_C534) is what this fix targets.Fixes #866