Conversation
Pair physical press and release with Fn through shared held-input ownership. Add the macOS action picker entry, localization, cancellation handling and IPC protocol 31. Cover lifecycle, wire and CLI compatibility, and document user validation and the local DMG.
|
| if binding.is_some_and(|binding| { | ||
| binding.click_action().requires_physical_release() | ||
| || matches!(binding, Binding::Clicks(_)) | ||
| || matches!(binding, Binding::LongPress(long) if long.double_click().is_some()) | ||
| }) { |
There was a problem hiding this comment.
Pulse-only HID++ controls now reject every Binding::Clicks binding before emitting a runtime event. For example, a binding with Click set to Copy and Hold set to Paste performs no action on hardware that only reports pulses, even though pulse-only sources are expected to fall back to the click action. Please reject only actions that require a physical release, or preserve the configured click fallback.
|
|
||
| ## Scope and prerequisites | ||
|
|
||
| Applies to keyboard-chord and double-click builds using IPC protocol 33. |
There was a problem hiding this comment.
This guide identifies these builds as IPC protocol 33, but the implementation and wire-format test pin protocol 34. Because the GUI and agent require matching protocol versions, this can lead readers to pair incompatible builds that cannot connect. Please update the guide and document what protocol 34 adds.
| Globe/Fn is not a portable USB keyboard usage and cannot be entered as | ||
| `CustomShortcut = "Fn"`. This action is hidden on Linux/Windows, where execution | ||
| is unsupported. It is not offered in gesture editors or Actions Ring slots. | ||
| Pulse-only hardware, deferred gesture/short/long actions, and direct one-shot | ||
| execution reject it rather than opening and immediately closing voice input. | ||
| Use a single binding on a button with real down/up edges. |
There was a problem hiding this comment.
Fn guidance contradicts support
This section says CustomShortcut = "Fn" cannot be entered, but the new KeyCombo parser and keyboard editor support Fn, including modifier-only chords, and a custom shortcut emits it as a balanced tap on macOS. This contradiction may cause users to avoid a supported configuration. Please distinguish an immediate Fn custom-shortcut tap from HoldGlobeKey and lifecycle-held shortcuts.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
No description provided.