Skip to content

fix(linux): add a Spanish comment to the desktop entry - #1468

Open
eibidia wants to merge 1 commit into
AprilNEA:masterfrom
eibidia:fix/linux-desktop-entry-es
Open

eibidia wants to merge 1 commit into
AprilNEA:masterfrom
eibidia:fix/linux-desktop-entry-es

Conversation

@eibidia

@eibidia eibidia commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Summary

packaging/linux/desktop/openlogi.desktop has no localized keys, so GNOME and KDE show the English Comment in the app launcher whatever the session language is. This adds a Spanish one.

Changes

  • packagingComment[es] added directly after Comment, where the XDG Desktop Entry spec convention places localized variants. Name=OpenLogi is a brand and stays as is; Comment is the only prose in the file. Other languages can add their own Comment[xx] line the same way.

Testing

  • Non-Rust diff: no cargo command applies.
  • Checked the file against the Desktop Entry key grammar with a script (desktop-file-validate is not available on macOS): the first line is the [Desktop Entry] group, every entry matches Key[locale]=value, no key is duplicated, the file is valid UTF-8, and Comment[es] immediately follows Comment.
  • Not run: typos. .config/typos.toml does not exclude this file, so the job will read the Spanish words; none of them is a known English misspelling, but CI is the confirmation.
  • Not runtime-tested on Linux. To check: install the package, set the session language to Spanish, and hover or search OpenLogi in the GNOME Activities overview.

The desktop entry had no localized keys, so GNOME and KDE showed the
English Comment in every locale. Add Comment[es], next to the default as
XDG convention places it.
@eibidia
eibidia requested a review from AprilNEA as a code owner September 17, 2026 08:52
@greptile-apps

greptile-apps Bot commented Sep 17, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the localized desktop-entry key is valid and consistently included in supported Linux packages.

Summary

Adds a Spanish localized Comment to the Linux desktop entry so compatible desktop environments can display Spanish launcher metadata.

  • Preserves the existing English comment as the fallback.
  • Applies consistently across native, direct-install, and Nix packaging paths.

Reviews (1) · Last reviewed commit: "fix(linux): add a Spanish comment to the..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant