Conversation
The desktop entry had no localized keys, so GNOME and KDE showed the English Comment in every locale. Add Comment[es], next to the default as XDG convention places it.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packaging/linux/desktop/openlogi.desktophas no localized keys, so GNOME and KDE show the EnglishCommentin the app launcher whatever the session language is. This adds a Spanish one.Changes
Comment[es]added directly afterComment, where the XDG Desktop Entry spec convention places localized variants.Name=OpenLogiis a brand and stays as is;Commentis the only prose in the file. Other languages can add their ownComment[xx]line the same way.Testing
desktop-file-validateis not available on macOS): the first line is the[Desktop Entry]group, every entry matchesKey[locale]=value, no key is duplicated, the file is valid UTF-8, andComment[es]immediately followsComment.typos..config/typos.tomldoes not exclude this file, so the job will read the Spanish words; none of them is a known English misspelling, but CI is the confirmation.