refactor(environment): unify oasys and main branch into one#123
Open
Thierry-git wants to merge 17 commits into
Open
refactor(environment): unify oasys and main branch into one#123Thierry-git wants to merge 17 commits into
Thierry-git wants to merge 17 commits into
Conversation
…as environment.ts This is a step to enable us to reuse the same codebase (main) on oasys and in development.
Stabilize crontab job paths to /opt/aquadash/sensors symlink (created by install.sh). This allows there to be a unique version of these jobs, which is a step towards not needing a separate oasys branch.
…inux-first project CRLF default had been causing friction for many scripts and files, corrupting them upon committing
… the app container with hot reload enabled
…differences between main and oasys branches The maximal sensor history query length can be specified in seconds. This then filters the constant in constants.ts.
…ated from the defaults automatically if they don't exist Moreover, a check is performed so as not to deploy pointed to localhost-like SERVER_URL values accidentally.
…cumentation consequently
… and sent with respect to UTC in the backend
… current nginx setup nginx expects /var/www/aquadash/browser and we were giving /var/www/aquadash It is indeed cleaner to unpack browser, but we will not apply this fix for now
…obs when mutating them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify
oasysandmainThe differences between both can be reduced to setting and environment variables. This PR realizes this. It was tested on Oasys and in a dev environment successfully, which proves that this is true and is workable in the future. Concretely...
SENSORS
Sensors/.envFRONTEND
environment.example.tsandapp-settings.example.ts, which get copied when project is built for the first time asenvironment.tsandapp-settings.tsdeploy.shnow checks that these files exist and also protects against misdeploying with SERVER_URL=localhost-like URLsinstall-softwares.sh, which was deprecatedBACKEND
MISCELLANEOUS
Notes
Closes #120.