Regenerate CI workflows with xmsconan 2.15.4 - #197
Merged
Conversation
Also tracks the generated .flake8 and pytest.ini, matching xmscore. The new flake job renders .flake8 during CI, so this is for local parity: a bare 'flake8 _package' now works without running the generator first.
xmscore 7.0.8's binaries were published under an unpinned conan. Now that the workflows pin conan~=2.31.0 the computed package_id no longer matches anything on the remote, so macOS builds failed with: ERROR: Missing binary: xmscore/7.0.8:2ca6c31bc94272eed28eeaca61e847eea0fc1a32 7.0.10 is built under the same conan pin, so its binaries resolve.
7.0.11 is the first xmscore built both under conan~=2.31.0 (so its binaries resolve against the remote) and with xmsconan 2.16.0 (so its library carries the testing helpers this repo links: ttEqualPointsXYZ, ttTextFilesEqual, ...). 7.0.10 satisfied only the first condition, which fixed the missing-binary error but surfaced undefined references at link time instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerates CI and build files with xmsconan 2.15.4 (was 2.12.2).
Changes
xmsconan_gen build.tomlto render.flake8, and runs plainflake8 _package— the inline flake8 arguments are gone, so.flake8is the single lint source of truth.xmsconan==2.15.4(wasxmsconan>=2.12.2) andconan~=2.31.0(was unpinned).--artifacts-dirand uploaded.if: ${{ ... }}expressions normalized toif: ...(equivalent)..flake8andpytest.ini, matching xmscore. CI renders.flake8itself during "Generate Build Files", so this is purely for local parity — a bareflake8 _packagenow works without generating first. Happy to drop these two files if you'd rather keep them as untracked build artifacts.Note on actions/checkout
This repo's
actions/checkout@v4(from b20fc15) is preserved. Regenerating with 2.15.3 would have reverted it to@v2, because the xmsconan template still emitted v2. That was fixed upstream in xmsconan#81 and released as 2.15.4, which this PR generates from — so the reviewed v4 upgrade survives regeneration from here on.Release notes: https://github.com/Aquaveo/xmsconan/releases/tag/2.15.4