Bump xmscore/xmsgrid and regenerate CI with xmsconan 2.18.0 - #95
Merged
Conversation
Third library onto the VS2019 bridge, after xmscore 7.0.12 and xmsgrid 9.0.11. **xmscore 7.0.11 -> 7.0.12, xmsgrid 9.0.10 -> 9.0.11.** xms_dependencies pins exact versions, and neither 7.0.11 nor 9.0.10 was ever built for msvc 192 -- only 7.0.12 and 9.0.11 exist on aquaveo-vs2019. Left at the old pins the VS2019 build fails at graph resolution before compiling anything. Both bumps are inert for the msvc 194 / gcc / clang builds. Each of those releases contained only its own dependency-and-CI bump, no C++ source change, and each is published on both remotes at a single matching recipe revision (xmscore c58afa49..., xmsgrid 66ac6991...). **xmsconan 2.16.0 -> 2.18.0.** CI has to generate the recipe with the same xmsconan the manual VS2019 track uses. XmsConan2File.export() copies xms_conan2_file.py into the export folder, so its contents feed the recipe revision hash, and 2.18.0 changes that file by 192 lines (the msvc 192 fork). Generating with 2.16.0 in CI and 2.18.0 locally would publish different rrevs for the same version, leaving aquaveo-stable and aquaveo-vs2019 out of step on what reads as one release. Nothing else in the generated output moves -- the CI diff is pins only. build.toml declares no [vs2019_dependency_overrides] table, so the generated conanfile.py gains no new attribute, and on any toolchain that is not msvc 192 the dependency graph is unchanged. 2.17.0 floated generated CI onto >= with --upgrade, so this should be the last regeneration commit this repo needs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third library onto the VS2019 bridge, after xmscore 7.0.12 and xmsgrid 9.0.11. Six lines, two coupled changes.
1. Dependency bumps — required, not routine
xms_dependenciespins exact versions, and neither 7.0.11 nor 9.0.10 was ever built for msvc 192. Only 7.0.12 and 9.0.11 exist onaquaveo-vs2019, so left at the old pins the VS2019 build of xmsinterp fails at graph resolution before compiling a single file.Both bumps are inert for the VS2022 side. Each of those releases contained only its own dependency-and-CI bump — no C++ source change — and each is published on both remotes at a single matching recipe revision (
xmscore c58afa49…,xmsgrid 66ac6991…).2. xmsconan
==2.16.0→>=2.18.0CI must generate the recipe with the same xmsconan the manual VS2019 track uses.
XmsConan2File.export()copiesxms_conan2_file.pyinto the export folder, so its contents feed the recipe revision hash, and 2.18.0 changes that file by 192 lines (the msvc 192 fork). Generating with 2.16.0 in CI and 2.18.0 locally would publish different rrevs for the same version.Blast radius on the VS2022 side: none
[vs2019_dependency_overrides]table, so the generatedconanfile.pygains no new attribute.xms_dependencies = ["xmscore/7.0.12", "xmsgrid/9.0.11"],testing_framework = "cxxtest"(relevant becausegtest/1.17.0has no msvc 192 build).Last regeneration commit
2.17.0 floated generated CI onto
>=with--upgrade, so future xmsconan releases arrive on the next CI run. The flake job picks up--upgrade, which it lacked under the==pin.🤖 Generated with Claude Code