Open
Conversation
sampoearas
commented
Jun 27, 2019
sampoearas
commented
- Updated readme layout
- Updated Install Steps with IOM install
- Updated design of webpage (colors, font, text placeholders)
- Updated screenshot with new design
- Tested project on Aras v11.12-15, v12.0
- Updated readme layout - Updated Install Steps with IOM install - Updated design of webpage - Updated screenshot with new design - Tested project on Aras v12.0
EliJDonahue
requested changes
Jul 23, 2019
Member
EliJDonahue
left a comment
EliJDonahue
left a comment
There was a problem hiding this comment.
There are a lot of new files added that aren't needed and shouldn't be included in the repository, like the sqlite3 folder, .vs folder, all of the dlls in the bin folder, and everything in the obj folder. Look up a .gitignore template for this type of Visual Studio project, add it to your local repo, and ignore/untrack these files.
README.md
Outdated
|
|
||
|  | ||
| *The PR Web Page with log in credentials and PR data filled out* | ||
|  |
Member
There was a problem hiding this comment.
This url doesn't work. GitHub is case-sensitive, and the actual file name has a lower case file extension.
EliJDonahue
reviewed
Jul 23, 2019
README.md
Outdated
| 2. Start the External_Input_Example project. | ||
| 3. Wait for the the web page to load | ||
| 1. Select the browser you want to run it in. | ||
| 3. Wait for the the web page to load. |
Member
There was a problem hiding this comment.
Repeated "the". Please fix.
Revert ".gitignore is now working" This reverts commit f0fc00081cabff191de9ab573fa15a1bd851f52d. Update .gitignore file - bypass Aras DLLs Apply .gitignore prefs Revert "Apply .gitignore prefs" This reverts commit e8621e60fb0b13e8087ee3225ed3d89b844d5b5b. Update gitignore Apply .gitignore prefs Revert "Apply .gitignore prefs" This reverts commit 457f5341e94b2082dc3ddce304ac5bb20e647f15. update gitignore Apply .gitignore prefs update gitignore Apply .gitignore prefs update gitignore Apply .gitignore prefs
removed double "the" in usage
Author
|
Changes made. gitignore added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.