update faction page#10
Conversation
Tyler-RNG
left a comment
Tyler-RNG
left a comment
There was a problem hiding this comment.
Good progress towards better looking. Needs more styling to be clean and full use of space.
Also check if this is mobile compatible by mimicking mobile device on your computer to ensure the format fits.
I do not want any scrollbars on the site so make sure that the FULL WIDTH of the screen is used so no scrolling needs to be done. (scrolling is ok on mobile)
|
|
||
| {/* Grid Factions Available */} | ||
| <section className="w-full max-w-full mt-10 px-0"> | ||
| <h2 className="text-2xl md:text-3xl font-bold mb-4 text-blue-400 px-4">Factions Available</h2> |
There was a problem hiding this comment.
Please do not use language like "available". The user cannot change factions so say something like "Your faction"
and "Opposing factions"
| <Footer darkMode={darkMode} /> | ||
|
|
||
| {/* Custom Animations */} | ||
| <style>{` |
There was a problem hiding this comment.
Please fix the style up so it uses the full WIDTH of the page. Things seem scrunched up and should spread out more
Use the red space
| </ul> | ||
| )} | ||
| <div className={`grid grid-cols-2 gap-4 ${theme.container} bg-opacity-60 rounded-xl p-4 mb-3 text-base`}> | ||
| <div> |
There was a problem hiding this comment.
A lot of this can be done in the css. try to use css more and clean up all the "inline" styling
| <p className={`text-base mb-3 ${theme.text}`}>Offer praise once daily. Build streaks for RUNE rewards!</p> | ||
| <div className={`grid grid-cols-2 gap-6 ${theme.container} bg-opacity-70 rounded-xl p-6 mb-3`}> | ||
| <div> | ||
| <div className={`text-base mb-2 ${theme.text}`}>Your Offerings: <span className="font-bold float-right">{userOfferings?.IndividualOfferings || 0}</span></div> |
There was a problem hiding this comment.
Clean up the styling for this. things seem a bit cramped. see if you can make this look more gamified
Things are looking TOOO wide you cna set a max width. Also there are still sliders for the top and the bottom which I dont want. The working was cleaned up a a bit but the changes to remove the inline and to move to css were not done |
2 participants
No description provided.