feat: emit session recovery events - #107
Merged
Merged
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
divo12 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
codeant-ai
Bot
added
the
size:L
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
There was a problem hiding this comment.
divo12 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
divo12 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
divo12 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Address CodeAnt: the return contract includes evaluation, with explicit None when the evaluator is disabled. Co-authored-by: Cursor <cursoragent@cursor.com>
feat(context): expose typed evaluator carryover and hook roles
Move planner/generator/evaluator protocol into packaged standing orders selected by session role; load employee craft from .harness/AGENTS.md in the context tier; slim head intents to data envelopes. Co-authored-by: Cursor <cursoragent@cursor.com>
Omit packaged standing orders when a role manifest requests replace so subagent isolation and custom roles keep their contract. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep gen/eval user turns as data-only beat packets, share format_sprint_beat, retire oracle into verification, align planner SO with read-only tools, harden ask_until_parsed for session reuse, and surface retry/skip/escalate in StdioObserver. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace dict[str, Any] observer payloads with frozen event classes, merge tiny modules into a readable layout, and drop getattr/setattr colour hacks. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop event.kind / content_preview / usage_from_event, store typed handoff artefacts, bare-JSON evaluator parse, and collapse thin prompt block wrappers. Net ~270 lines shorter. Co-authored-by: Cursor <cursoragent@cursor.com>
Evaluator verifies in-session via bash; run_oracle had no production callers. Keep run_verification as the real shell runner. Co-authored-by: Cursor <cursoragent@cursor.com>
Evaluator verifies in-session via bash; the Spec 12c runner/report/UI seam and tech-debt filer had no production callers. Co-authored-by: Cursor <cursoragent@cursor.com>
List available subagents in the system-prompt brief like skills. Keep spawn_subagent wire schema as a typed enum only; spawn usage policy moves into Dream standing orders. Co-authored-by: Cursor <cursoragent@cursor.com>
Wire ToolCatalogue from the same role-filtered tool set as the request tools array (builtin, per-repo, MCP) so the brief matches the callable surface. Schemas stay on the provider wire. Co-authored-by: Cursor <cursoragent@cursor.com>
Split tool brief into Tool definitions vs MCP & dynamic tools by ToolSource; rename Skills and Subagent definitions headers. Park deferred load_tool wire work for a follow-up PR. Co-authored-by: Cursor <cursoragent@cursor.com>
… green) - dream.runner now re-exports UsageMeter so Chorus's dream_beat.py import keeps working after _usage.py removal - remove worktree_root passthrough that make_evaluator_head no longer accepts - merge split observe import in test (ruff I001)
feat(prompts): centralize cache-stable session prompt assembly
Add dream.context.breakdown with Hermes-compatible categories and Session.context_breakdown() for a future REPL /context command. Co-authored-by: Cursor <cursoragent@cursor.com>
Bound skills/memory sections, read system prompt and tools from the engine contract, and use the shared 200k window fallback. Co-authored-by: Cursor <cursoragent@cursor.com>
…text Rewrite the context breakdown to consume typed objects end-to-end instead of re-parsing the raw provider wire: - Introduce PromptSurfaces (StablePromptBlock / ContextPromptBlock / role instructions / AdvertisedTool tuple) held on the QueryEngine; the engine no longer needs a raw system_prompt string plus tools_wire dicts. - AdvertisedTool carries a token estimate of its own OpenAI tools wire entry plus ToolSource provenance, so MCP tools split out without name sniffing; only subagent-named builtins need the small name set. - compute_context_breakdown reads the typed prompt blocks and delegates transcript tokenization to estimate_conversation_tokens (shared with the compactor), splitting [Compaction summary...] messages into their own bucket. No Any, dicts, getattr, or regex over rendered text. - Build the typed surfaces once in _build_session_engine (replacing the private _assemble_system_prompt string-only helper) and render the same string the streamer needs from them. - session.context_breakdown() now returns ContextBreakdown | None straight off the engine's prompt_surfaces (no getattr), and tests exercise the typed API with a real compaction-summary conversation.
feat(context): Cursor-style context breakdown pie
Rebase onto main (keep #112 context breakdown). Drop the PR's reimplemented context pie and getattr session wiring. Apply ≤4 ephemeral breakpoints via frozen OpenAIChatMessage envelopes when ProviderCapabilities.prompt_cache is set. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace to_wire dict helpers with OpenAIChatMessage.to_json_object / encode_openai_messages at the HTTP boundary only. Co-authored-by: Cursor <cursoragent@cursor.com>
Compaction shares Dream-owned common standing orders via CompactionPromptParts / OpenAIChatMessage envelopes (workspace context stays on the user message). Stacked on cleaned #113; no context pie reimplementation. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop unused JsonValue alias, move assistant tool_calls wire encoding into the OpenAI adapter, and inline message JSON at call sites. Co-authored-by: Cursor <cursoragent@cursor.com>
Narrow OpenAIChatMessage list before apply_cache_control and align httpx stream callable message param with StreamChatCompletion. Co-authored-by: Cursor <cursoragent@cursor.com>
Use live stable_block.render() for compact cache prefix alignment, restrict workspace context to skill/memory catalogues only, add typed OpenAIAssistantToolMessage wire types, CompactionChatRequest, and validate summariser JSON payloads before parsing. Co-authored-by: Cursor <cursoragent@cursor.com>
feat(compact): reuse stable+context assembler prefix
feat(prompts): Hermes-style cache_control + stable tool prefix
Ship explore/plan/verify builtins, wire model/overlay/spawned_by/isolation on the live path, add delegation poll/stop for background spawns, and keep sync as the beat default with a host tool blocklist. Co-authored-by: Cursor <cursoragent@cursor.com>
Scope asynchronous delegation to its owning session and make overlays and worktree execution fail closed so the lean subagent catalog is safe to expose. Co-authored-by: Cursor <cursoragent@cursor.com>
feat(subagents): lean Hermes+Claude catalog with wired isolation
Carry typed tool result metadata through RunTaskObserver so downstream adapters can consume structured evidence without parsing text. Co-authored-by: Cursor <cursoragent@cursor.com>
fix(runner): preserve structured tool results in events
Seal session and trace JSON into public typed immutable values so control-plane readers cannot mutate captured execution state. Co-authored-by: Cursor <cursoragent@cursor.com>
feat(observability): expose immutable runtime snapshots
Preserve snapshot truth across resume races and expose recovery actions without allowing observers to control session lifecycle. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the reviewed current-main implementation while joining the original PR branch without rewriting remote history.
|
Too many files changed for review (128 files, 100 file limit). Bypass the limit by tagging |
|
Skipping CodeAnt AI review — this PR changes more than 100 files, which usually means a migration, codemod, or vendored drop. Line-level review on diffs this large produces duplicate findings on the same rewrite pattern and drowns out anything that actually matters. If you still want a review, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
role.session.recoveredwhen Dream resets or bypasses an unreadable persisted role sessionsession_idfrom the failedrequested_session_idTests
pytest tests/test_runner/test_role_session_resume.py tests/test_runner/test_observer.py -qruff check src/dream/runner/_role_session.py src/dream/runner/_observer.py tests/test_runner/test_role_session_resume.py tests/test_runner/test_observer.pymypy src/dream/runner/_role_session.py src/dream/runner/_observer.pypytest -qwith the venv onPATHNotes
AnyannotationsCodeAnt-AI Description
Report when a role session is recovered after a resume failure
What Changed
Impact
✅ Clearer session recovery status✅ Fewer stranded role sessions✅ Protected cross-workspace session history💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.