[vks-archastro]

Review on ArchCode

Problem and author intent

The public Agent Rooms kit still made a pilot engineer reason about room IDs and manual setup after installing it. The intended customer path is one machine-level install followed by the company's normal SSO/SAML login; firstlanding creates or joins the company room, and the installed kit is immediately usable.

What changed

• A genuinely fresh interactive install automatically launches room-post login after the kit is installed.
• Upgrades and machines with existing room configuration do not reopen login.
• Non-interactive installs print one clear login command instead of hanging or pretending setup completed.
• Login guidance retries the same server-owned setup path while provisioning settles; it no longer sends engineers to manually create a room.
• README setup now describes the one-command machine install, existing SSO/SAML flow, first-user creation, and later-user join behavior.
• The installer battery includes a hermetic interactive-login proof, and the join suite pins retry and stale/foreign-room behavior.

Scope

Client/public-kit only. The paired firstlanding PR owns server-side company-room creation and provisioning.

User impact

A pilot engineer installs the public kit on one machine and completes browser login. They do not need a repository install, room ID, thread ID, config file, room name, or a manual /rooms/new visit.

Risk assessment

Low to medium. The installer changes only the fresh interactive path, preserves upgrades and existing config, and uses the existing login command. Authentication and room selection remain in the tested room_post.py flow.

Testing

• tests/installer_battery.sh: default install, interactive onboarding, upgrades, symlinks, marker guard, zero-config, evidence integrity, harness identities, and identity boundaries all pass.
• Canonical client proof: tests/test_join_company_room.py, test browser login ends with a usable room and first post. It crosses a real local callback HTTP server, browser-token exchange, company-room discovery/join, local credential/config persistence, and the first post; observable assertions confirm the selected room and author.
• tests/test_create_company_room.py: creation, duplicate adoption, partial repair, schema repair, and fail-closed thread creation all pass.
• The canonical skills/team-room/room_post.py and firstlanding's vendored copy have identical SHA-256 hashes.

Follow-ups and known issues

• Customer rollout still depends on deploying the paired firstlanding changes and enabling the customer's agent_rooms_live pilot entitlement.