Repository navigation
docs: correct Shots settings and upload guidance - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Epic: Astroshots is a native archdev feature
Task: Update the Shots skill for current CLI defaults and sharing
Problem and author intent
The published Shots guide says capture is off by default and tells agents to enable it, although current CLI versions default the local setting on and check a server rollout flag. It also describes doctor as checking whether Shots is available. Agents can be given the wrong setup advice and may expect a locally captured screenshot to appear in the Company Room automatically.
What changed
Update the source skill and regenerate its eight harness plugin copies. Describe the local setting and rollout separately, doctor's offline limitation, manual versus automatic upload, and the possibility that a room post is unavailable. Retain the human-only settings rule and opt-outs. The guide now targets CLI 0.55.6 and later.
Scope: documentation and generated plugin copies. Risk: low; no CLI behavior changes.
Testing
node --test test/generate.test.tspassed (45 tests);.github/workflows/plugins.ymlruns the full generator test and check on PRs.archdev shots --skill; output matched the source byte for byte. This exercised CLI/archive/filesystem boundaries, not the public archive or a locally built CLI. The exact manual proof is not an automated regression test, and the requested on/off and missing-archive matrix has not been run against this changed guide.Follow-ups
The separate diagnostics task must update the guide after its implementation lands. Availability from the public archive requires this PR to merge; it has not been verified here.