Repository navigation
Remote manifests are HMAC-signed and verified - #169
Merged
calvin-archastro merged 3 commits intoOct 21, 2026
Merged
calvin-archastro merged 3 commits into
calvin-archastro merged 3 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
ArchDev is watching this pull request. State: settled (cycle 3 of 3 for head be8611e).
Paused by the |
CodeQL flagged 5 rust/hard-coded-cryptographic-value alerts (src/cache/signature.rs:198,199,206,208,209), all literal "test-key"/"other-key" HMAC keys in valid_signature_hits_and_tamper_or_wrong_key_misses. The test now uses per-run getrandom keys; behavior and assertions are unchanged. cargo test cache::signature (2 passed) and cargo clippy --all-targets --all-features -D warnings are clean. Archdev-Job: job_5ebc93765b1b7473fb3addab Co-Authored-By: ArchDev <archdev@archastro.ai> Archdev-Model: anthropic/claude-opus-5.5
Archdev-Job: job_4d3bc1c1775ac49244b88121 Co-Authored-By: ArchDev <archdev@archastro.ai> Archdev-Model: anthropic/claude-opus-5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic: Aster restores real build artifacts from a shared cache, including the GitHub Actions cache
Task: Remote manifests are HMAC-signed and verified
Local git hooks skipped: pre-push on the publish push. CI is the gate for what those hooks check.
Problem and author intent
ArchDev could not generate review prose. This ready-for-review PR preserves the verified branch so the exact diff can be reviewed.
What changed
Changed paths include Cargo.lock, Cargo.toml, src/cache/aster_srv.rs. Review the commits and files directly.
Scope
Determine backend, frontend, or full-stack scope from the diff.
Risk assessment
Risk is unclassified because generated review metadata was unavailable.
User impact
Determine user impact from the diff.
Testing
Review the daemon job output for the checks executed against this exact head.
Follow-ups and known issues
Semantic hunk metadata is absent; reviewers must inspect the complete diff.