fix: make SpellCard footnotes reactive via computed#38
Open
ArchiDevil wants to merge 1 commit into
Open
Conversation
Remove shared mutable footnotes array that was mutated from two
separate computed() properties (components and castTimes). The order
of computed evaluation is not guaranteed by Vue, so footnote indices
could swap unpredictably.
Refactored to pure computed chain:
- materialComponent: extracts material component string
- componentMatch: single regex exec, shared by materialComponent and components
- castTimeInfo: returns {label, footnote} in one pass
- footnotes: built from materialComponent + castTimeInfo
- materialComponentFootnote / castTimesFootnote: derived indices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SpellCard had a shared mutable
footnotes: string[]array that was mutated from two separatecomputed()properties (componentsandcastTimes). Vue does not guarantee the order of computed evaluation, so footnote indices could swap unpredictably between renders.The footnote index refs (
materialComponentFootnote,castTimesFootnote) depended onfootnotes.lengthat mutation time — non-deterministic.Changes
Refactored to a pure computed chain — no side effects, no shared mutable state:
componentMatch— single regex exec, shared by derived computedsmaterialComponent— extracts the material component stringcomponents— no longer mutates anything, just parsescastTimeInfo— returns{label, footnote}in one pass (replacescastTimes+ footnote mutation)footnotes— built deterministically: material component first, then cast timematerialComponentFootnote/castTimesFootnote— derived from whether the corresponding footnote existsAlso removed
footnotes.length = 0from thewatch— no longer needed sincefootnotesis computed.Template is unchanged.