refactor: extract generic fetchAllPaginated helper#39
Open
ArchiDevil wants to merge 1 commit into
Open
Conversation
All list endpoints (spells, feats, backgrounds, magic-items, facilities, spell-cards) had the same pagination boilerplate: get count, loop with sequential await, concat results, map types. Replaced with a generic fetchAllPaginated<DirectusT, ApiT> helper that: - Centralizes the pagination logic - Uses Promise.all instead of sequential requests (parallel fetch) - Reduces each endpoint to ~15 lines of config + mapper Also closes #5 (sequential requests performance issue).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All list endpoints (, , , , , ) had the same ~40-line pagination boilerplate: get count → loop with sequential → concat → map types.
Extracted a generic
fetchAllPaginated<DirectusT, ApiT>helper that:server/utils/fetchAllPaginated.ts)Promise.allinstead of sequential requests — pages fetch in parallelChanges
spells.tsfeats.tsbackgrounds.tsmagic-items.tsfacilities.tsspell-cards.tsfetchAllPaginated.tsNet -113 lines, and adding a new list endpoint is now trivial.
Bonus
Also fixes the sequential-fetch performance issue (#5 from the code review) — all pages now fetch in parallel.