fix: only swap YTM thumbnail for music videos, not audio tracks#949
Merged
rukamori merged 2 commits intoJun 30, 2026
Merged
Conversation
…nto fix/thumbnail-swap-music-video-only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
rememberThumbnailSwapStatecomposable was attempting to load YTi.ytimg.comthumbnails for every item with a non-nullvideoId, regardless of whether it was a music video or an audio track. This caused "Music" type items (1:1 YTM art) to silently get their thumbnail swapped to YT lower-quality video thumbnails.The static
isMusicVideoflag frommusicVideoType(OMV/UGC) misses some video items. This fix adds a runtime check using Media3Player.getTracks()to detect actual video tracks at playback time.Changes:
hasVideoTracksStateFlow toPlayerConnection, initialized fromplayer.tracksand updated ononTracksChangedrememberThumbnailSwapStateto accepthasVideoTracks: Booleanand useisMusicVideo || hasVideoTrackshasVideoTracksfromplayerConnectionThe
shouldAttemptYTflag now requiresvideoId != null && !lowDataMode && (isMusicVideo || hasVideoTracks)— the runtime thumbnail swap fires only when the item is statically flagged as a music video OR the Media3 player reports active video tracks.