Add selectable download storage location with embedded song metadata#951
Open
agupta07505 wants to merge 4 commits into
Open
Add selectable download storage location with embedded song metadata#951agupta07505 wants to merge 4 commits into
agupta07505 wants to merge 4 commits into
Conversation
…sting Media3 offline playback path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Adds a selectable downloaded-song export location under Settings > Storage. New completed downloads are exported as locally accessible audio files named
SongName - ArtistName.ext. Supported metadata is embedded directly into the exported audio file.Linked Work
Change Type
Affected Surfaces
:app:core:lyrics:lastfm:canvas:shazamkit:spotifycoreScreenshots / Recordings
Video Link:
refer-this-video.mp4
Behavior Notes
Users can open Settings > Storage > Downloaded songs > Select location and choose a folder using Android's system folder picker. Completed downloads are exported to the selected folder as normal audio files named
SongName - ArtistName.ext; if no folder is selected, the app falls back to its internal exported songs folder. Metadata is embedded into supported audio formats where possible, and no new.jsonsidecar file is created.Architecture Checklist
Loading,Success,Empty, andErrorwhere this PR introduces or changes screen state.runBlockingis introduced in app execution paths.Compose / Material Checklist
collectAsStateWithLifecycle().@Immutableor@Stable.keyvalues and explicitcontentType.derivedStateOfwhere appropriate.stringResource()and duplicated visible strings on the same screen are avoided.WindowInsetscorrectly when this PR changes screen layout.Concurrency / Performance Checklist
viewModelScopeor an existing lifecycle-owned application/service scope.Dispatchers.IOorDispatchers.Default.Data / Persistence Checklist
app/schemas.Playback / Integration Checklist
universal,arm64,armeabi,x86, andx86_64variants.Localization / Assets Checklist
Privacy / Security Checklist
Verification
assembleGmsMobileUniversalDebugshould pass after the Kotlin receiver fix inDownloadedSongExporter.kt.Reviewer Focus
Please review
StorageSettings.ktfor the folder picker UX and persisted URI permission handling,DownloadUtil.ktfor completed-download export hooks, andDownloadedSongExporter.ktfor file naming, selected-folder export behavior, and embedded metadata writing.Release Notes
Downloaded songs can now be exported to a folder you choose, with metadata saved inside supported audio files.