Skip to content

fix: reduce padding between contract and copy button in token details#1841

Draft
goga-m wants to merge 20 commits into
feat/mainsailfrom
fix/copy-button-spacing
Draft

fix: reduce padding between contract and copy button in token details#1841
goga-m wants to merge 20 commits into
feat/mainsailfrom
fix/copy-button-spacing

Conversation

@goga-m
Copy link
Copy Markdown
Contributor

@goga-m goga-m commented May 7, 2026

Summary

Closes https://app.clickup.com/t/86e12bmpa

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
arkvault Ready Ready Preview May 29, 2026 12:08pm

Request Review

Copy link
Copy Markdown
Contributor

@ItsANameToo ItsANameToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image this seems to cut off part of the address' last character

@ItsANameToo ItsANameToo marked this pull request as draft May 8, 2026 09:30
@goga-m goga-m changed the title fix: reduce padding between address & copy button refactor: simplify and improve responsiveness in middle truncation component May 8, 2026
@goga-m goga-m marked this pull request as ready for review May 12, 2026 09:05
@goga-m
Copy link
Copy Markdown
Contributor Author

goga-m commented May 12, 2026

@ItsANameToo @samharperpittam @shahin-hq I simplified the address & middle truncation component to have css based responsive truncation. If we could have an overall look in case it doesn't break anything that would be great. Let me know. ty!

Copy link
Copy Markdown

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goga-m - a bit confused by this one.

Task linked is to reduce padding between Contract address and copy icon.

But it still seems to be the same as previously?

Image

@ItsANameToo ItsANameToo marked this pull request as draft May 15, 2026 14:52
This reverts commit ce810c4.
@goga-m goga-m changed the title refactor: simplify and improve responsiveness in middle truncation component fix: reduce padding between contract and copy button in token details May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants