Add custom defines support #218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support adding custom defines to BuildInfo which are injected into extra_hwdef.dat when generated.
Add text box to input custom defines to be passed to builder. Add custom_defines to BuildRequest schema and parse custom defines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a text box to the bottom of the new build page to input custom
#defines. Input is inDEFINE=VALUE, DEFINE=VALUEformat. These are parsed and injected into theextra_hwdef.datfile when setting up the build.Any custom defines are also output in the build log:
Tested locally in Docker and successfully built a version with custom
#defines injected. Leaving the box blank results in the current behaviour.Addresses #217