mavutil: add type annotations to mavfile subclasses (mavserial, mavud… - #1239
Open
khancyr wants to merge 1 commit into
Open
mavutil: add type annotations to mavfile subclasses (mavserial, mavud…#1239khancyr wants to merge 1 commit into
khancyr wants to merge 1 commit into
Conversation
peterbarker
reviewed
Jul 31, 2026
| pass | ||
|
|
||
| def recv_msg(self): | ||
| def recv_msg(self) -> Any: |
Contributor
There was a problem hiding this comment.
Why Any?
SHouldn't this be message-or-None?
Similarly elsewhere
…p, ...) Types FakeSerial and all mavfile subclasses: mavserial, mavudp, mavmcast, mavtcp, mavtcpin, mavlogfile, mavmmaplog, mavchildexec, mavwebsocket, and mavwebsocket_client. Dynamic/polymorphic attributes (sockets, serial ports, mmap objects, pipes) that hold different concrete types over their lifetime are annotated honestly as Optional/Any/cast() rather than forcing a single type mypy would then fight at every reassignment - e.g. mavserial.port is serial.Serial or FakeSerial, mavtcp.port is socket.socket | None, mavmmaplog.data_map is mmap.mmap | None. Note for reviewers: this PR is not yet 100% mypy-clean standalone - 10 residual "close() signature incompatible with supertype" errors remain because mavfile.close() itself (a separate, not-yet-submitted PR) still has a vestigial `n: Any` parameter no subclass override uses. That resolves once the mavfile base-class typing PR lands; tracking here so it isn't mistaken for something missed in this PR's own scope. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
khancyr
force-pushed
the
typing/mavutil-subclasses
branch
from
August 3, 2026 13:21
079cd5c to
313862b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…p, ...)
Types FakeSerial and all mavfile subclasses: mavserial, mavudp, mavmcast, mavtcp, mavtcpin, mavlogfile, mavmmaplog, mavchildexec, mavwebsocket, and mavwebsocket_client. Widens mavfile.recv()'s return type to bytes | str to honestly reflect what these overrides actually return (several fall back to "" on error paths).
This Only set annotation and don't touch anything else ! No code modification