Replace use of PluginManager with Cntlr.plugins#62
Draft
aaroncameron-wk wants to merge 1 commit into
Draft
Conversation
302ea88 to
80d350f
Compare
volodymyrtur-wk
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Refactor plugin invocation to align with the upcoming deprecation of the global
PluginManagerin Arelle. This update migrates logic to use thePluginProviderinstance provided by theCntlr(accessible viacntlr.plugins).Important
disableiXBRLViewerPluginInfocurrently disables theixbrl-viewerplugin if it is enabled. Enabling/disabling or otherwise manipulating plugin state through plugin metadata is not something we intend to support in Arelle going forward, so I've replaced it with only a log message (this can be elevated to a warning or error if desired).Important
XuleInterface.getXuleMethodhas been updated to more directly invoke the provided plugin hook. It does not rely on the explicit check for axuleplugin, though it will still trigger logs if the plugin is not configured as expected.review:
@freddym56
@Arelle/arelle