fix(operator): calendar failure cooldown + workflows.resume replay guard#466
Merged
Conversation
Wave 2 of the operator-reality fixes: - Dashboard calendar: runGogCalendarEvents gets a 5-minute failure cooldown. A broken gog state (expired OAuth, DNS outage) cost a blocking 10s shell-out per dashboard poll per queued account — a permanent tight error loop in dashboard-api.err.log. Now one real attempt per window; success clears the cooldown. - workflows.resume is no longer replayable: the approval row's "approved" status is terminal and never consumed, so gating on it alone let every repeat call re-execute the remaining pipeline (duplicate side effects — confirmed by the 2026-07-02 adversarial review). Resume now requires an atomic waiting_approval → running claim; force=true bypasses it (logged) to re-drive a run stuck in "running" after a dead resume. Live-data fixes alongside (not in diff): - "Morning Brief Podcast 2.0" (832f855e): podcast-script-agent and podcast-plan nodes had NO kind field, so validation couldn't see Podcast Plan upstream of Podcast Generate — the workflow failed in 33ms every morning and fed the failed-run-alerter. Kinds restored; workflows.dryRun now returns ok:true, issues:[]. Left parked. - Stale-run sweep: 21 workflow_runs + 29 job_runs stuck status='running' (some since March) marked failed with an audit note. - AppForge 401: verified already fixed by the #460 token-preference change — /api/apps returns 200 live; the audit's hits predated it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3dkQzz2mSrSNtGBE9cmXr
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 2 of the operator-reality fixes — see commit body for full detail. Code: calendar 5-min failure cooldown (kills the tight gog error loop), workflows.resume atomic replay guard (force=true escape hatch for stuck runs). Data fixes executed live: Morning Brief 2.0 node kinds restored (dryRun now clean, still parked), 21+29 stale running rows swept, AppForge 401 verified already fixed by #460.
🤖 Generated with Claude Code
https://claude.ai/code/session_01T3dkQzz2mSrSNtGBE9cmXr