fix(workforce): D9 stubbed calls no longer trip the simulate violation wire#467
Merged
Conversation
…n wire First live D9 run (conductor, 2026-07-02) proved the seam bug: the simulate tripwire counted the STUBBED doc_panel call as an executed external tool and blocked the run — but D9's whole point is that the call was structurally diverted into a proposed_action and executed nothing. Left as-is, every simulate run that records a proposal ends blocked, poisoning the grading runway the promotion gate depends on. New pure detectSimulationViolation (work-report-crosscheck.ts): the wire fires only for external tools that ESCAPED the stub — executed-tool telemetry minus tools with recorded proposed_actions. In simulate every write-capable tool is wrapped, so a proposal for a tool proves its calls were diverted; a telemetry entry with NO proposal means a call bypassed the stub, which is exactly what the tripwire exists to catch. Runner rewired to the shared detector; the block message now names the escaped tools precisely. +4 tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3dkQzz2mSrSNtGBE9cmXr
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the FIRST live D9 run tonight: the simulate tripwire counted the stubbed doc_panel call as an executed external tool and blocked the run — every proposal-recording simulate run would end blocked, poisoning the grading runway. New pure
detectSimulationViolation: fires only for tools that ESCAPED the stub (telemetry minus recorded proposals). +4 tests; runner suites green; tsc-since 0 net-new.🤖 Generated with Claude Code
https://claude.ai/code/session_01T3dkQzz2mSrSNtGBE9cmXr