feat(argentd): canary receipt methods over ws — status + generateLocalProof#468
Merged
Conversation
…lProof Adds the two RPC methods the installed-daemon canary contract requires: rustGateway.canaryReceipts.status and .generateLocalProof, advertised in the hello features.methods array. Receipts mirror the Node store shape (RustGatewayPromotionReceipt), cover all three canary surfaces with RUST_CANARY_DENIED + RUST_CANARY_DUPLICATE_PREVENTED codes, and are held in a capped in-memory hub store (regenerate proof after daemon restart). Adversarial-review fixes rolled in: control-char-safe JSON escaping (json_string/escape_json), JSON-aware param extraction so escaped reasons round-trip instead of poisoning the persisted receipt JSON, reason redaction (port of redactSensitiveText subset) so tokenMaterialRedacted:true is truthful, Node-parity limit clamping, duplicateKey derivation, and stableReceiptId surface sanitization. Verified end-to-end: gateway authority status-installed --generate-local-receipts → read-only-ready, smoke-local → passed, runtime probe methodAdvertised=true. 56 argentd tests green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3dkQzz2mSrSNtGBE9cmXr
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…, first hire, argentd contract) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3dkQzz2mSrSNtGBE9cmXr
… and live-verified Carries the evening handoff refresh (cherry-picked from chore/handoff-evening-2026-07-02, which never got a PR) and marks the in-flight argentd ws canary section SHIPPED with live :18799 evidence. Promotion checklist remainder item 1 closed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3dkQzz2mSrSNtGBE9cmXr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the last gap in the installed-daemon canary contract: argentd now speaks
rustGateway.canaryReceipts.statusandrustGateway.canaryReceipts.generateLocalProofover its ws JSON-RPC dialect and advertises both in the hellofeatures.methodsarray.RustGatewayPromotionReceipt(src/infra/rust-gateway-receipt-store.ts): all three canary surfaces,RUST_CANARY_DENIED+RUST_CANARY_DUPLICATE_PREVENTEDcodes,tokenMaterialRedacted:true,authoritySwitchAllowed:false.--generate-local-receipts.canaryFlagEnabledreads the sameARGENT_RUST_GATEWAY_CANARY_DENY_RECEIPTS=1flag the Node gateway uses.Adversarial review findings fixed (3-lens multi-agent review, 7 confirmed)
json_string/escape_json+ JSON-aware param extraction (find_param_json_string) — a reason with escaped quotes/newlines previously truncated or persisted invalid JSON into the receipt store, breaking every subsequent status response until restart.redactSensitiveTextpattern subset so a pasted secret in--reasoncan't be persisted under a receipt assertingtokenMaterialRedacted:true.trunc → clamp(1,100), negatives → 1),duplicateKeyderivation (idem-/cron-/run-bases),stableReceiptIdsurface sanitization (chat.send→chat-send), receipt Vec cap.Verification
argent gateway authority status-installed --generate-local-receipts --confirm-local-only→ read-only-ready, zero blockers, receiptProofComplete, probe methodAdvertised=trueargent gateway authority smoke-local --confirm-local-only→ passed, zero blockersNon-goals honored: no authority flips (Node stays live authority everywhere), loopback-only, zero TS changes.
🤖 Generated with Claude Code
https://claude.ai/code/session_01T3dkQzz2mSrSNtGBE9cmXr