Skip to content

feat(codex): parse custom tool call items with labels - #133

Draft
Ariestar wants to merge 1 commit into
mainfrom
feat/codex-custom-tool-calls
Draft

feat(codex): parse custom tool call items with labels#133
Ariestar wants to merge 1 commit into
mainfrom
feat/codex-custom-tool-calls

Conversation

@Ariestar

@Ariestar Ariestar commented Aug 12, 2026

Copy link
Copy Markdown
Owner

Support Codex's custom_tool_call / custom_tool_call_output response items, which the newer API uses for tool invocations.

Changes

  • codex.rs: parse custom_tool_call and custom_tool_call_output; tool calls and outputs now carry a label (tool name) and are linked by call_id
  • text.rs / workspace tests: content view renders structure runs as marker-only lines (<:tool:name call:>) with xN counts for identical labels
  • query/mod.rs: bump AGENT_CACHE_VERSION since the parsed block layout changed

Validation

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace ✅ (exit 0)

Summary by CodeRabbit

  • New Features

    • Improved tool-call tracking and output display, including custom tools and structured results.
    • Reading mode now shows tool and skill activity in execution order, with repeated tools summarized by count.
  • Bug Fixes

    • Improved association between tool calls and their corresponding outputs.
    • Updated session caching to ensure refreshed session data is used.
  • Tests

    • Added coverage for custom tool calls, output handling, marker ordering, and repeated tool counts.

Support the custom_tool_call / custom_tool_call_output response items:
tool calls and outputs now carry a label (tool name) linked by call_id,
and the content view renders structure runs as marker-only lines with
xN counts for identical labels. Bump the agent cache version since the
parsed block layout changed.
@Ariestar
Ariestar marked this pull request as draft August 12, 2026 10:05
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7dbce13c-9e9a-475f-84a5-83ac87cdfc9b

📥 Commits

Reviewing files that changed from the base of the PR and between 27d778a and 74fdb3e.

📒 Files selected for processing (4)
  • crates/sivtr-core/src/agents/codex.rs
  • crates/sivtr-core/src/query/mod.rs
  • src/tui/content/text.rs
  • src/tui/workspace/tests.rs
 __________________________________________________
< Turning your WTFs per minute into OMGs per hour. >
 --------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/codex-custom-tool-calls

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying sivtr with  Cloudflare Pages  Cloudflare Pages

Latest commit: 74fdb3e
Status: ✅  Deploy successful!
Preview URL: https://2594908e.sivtr.pages.dev
Branch Preview URL: https://feat-codex-custom-tool-calls.sivtr.pages.dev

View logs

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 74fdb3e742

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants