⚡ Optimize IconEditor preview rendering and fix line thickness logic#6
⚡ Optimize IconEditor preview rendering and fix line thickness logic#6google-labs-jules[bot] wants to merge 1 commit into
Conversation
Introduced `PreviewPainter` to handle drawing previews for Line and Rectangle tools on a separate canvas layer. This avoids copying the entire image buffer on every drag frame, significantly improving performance. Also fixed line thickness calculation logic in both `PreviewPainter` and `ImageUtils` to be more accurate (width ~= thickness) and fixed rectangle corner overdraw in preview.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
PreviewPainteras aCustomPainterto draw Line and Rectangle previews directly on the canvas.IconEditorto usePreviewPainterinstead of_previewLineand_previewRectanglewhich were modifying a copy of the image buffer.ImageUtils.drawLine(andPreviewPainter) to usethickness ~/ 2for correct width scaling.PreviewPainterto avoid overdrawing corners (important for semi-transparent colors).🎯 Why:
img.Imagebuffer (which can be large) on every frame. This caused lag on slower devices or large images. Using aCustomPainteris extremely lightweight.📊 Measured Improvement:
img.Image.from(image)andImageUtils.drawLine/Rect(pixel manipulation).setStateand a lightweight Canvas draw.PR created automatically by Jules for task 15277165099272657853 started by @ArinFaraj