Skip to content

refactor: remove bls keys from snapshot import#1379

Draft
oXtxNt9U wants to merge 13 commits into
fix/evm/consenus-contractfrom
refactor/evm/consensus-contract-snapshot
Draft

refactor: remove bls keys from snapshot import#1379
oXtxNt9U wants to merge 13 commits into
fix/evm/consenus-contractfrom
refactor/evm/consensus-contract-snapshot

Conversation

@oXtxNt9U

@oXtxNt9U oXtxNt9U commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • imported validators from a snapshot are now inactive
  • genesis block always registers genesis validators (even with a snapshot), so fresh genesis validators are the sole active set
  • genesis validators register with a 0 fee, on first round change the validator fee is updated to milestone value (otherwise it would mess with the supply when importing a snapshot)

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.86047% with 100 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.28%. Comparing base (fab9ba3) to head (cc0c840).
⚠️ Report is 25 commits behind head on fix/evm/consenus-contract.

Files with missing lines Patch % Lines
packages/evm/bindings/src/lib.rs 0.00% 58 Missing ⚠️
...ation-generator/source/generators/genesis-block.ts 82.89% 13 Missing ⚠️
...ckages/snapshot-legacy-importer/source/importer.ts 0.00% 9 Missing ⚠️
packages/evm/bindings/src/ctx.rs 0.00% 7 Missing ⚠️
...ration-generator/source/configuration-generator.ts 0.00% 6 Missing ⚠️
packages/evm-service/source/instances/evm.ts 33.33% 4 Missing ⚠️
packages/evm-consensus/source/deployer.ts 0.00% 2 Missing ⚠️
...ckages/snapshot-legacy-importer/source/defaults.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           fix/evm/consenus-contract    #1379   +/-   ##
==========================================================
  Coverage                      59.27%   59.28%           
==========================================================
  Files                            968      968           
  Lines                          65954    65938   -16     
  Branches                        1911     1911           
==========================================================
- Hits                           39097    39094    -3     
+ Misses                         26616    26603   -13     
  Partials                         241      241           
Flag Coverage Δ
contracts 92.47% <100.00%> (-0.54%) ⬇️
packages 59.07% <40.47%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oXtxNt9U
oXtxNt9U force-pushed the refactor/evm/consensus-contract-snapshot branch from e1f2a5f to cc0c840 Compare June 30, 2026 04:58
@oXtxNt9U
oXtxNt9U marked this pull request as draft July 6, 2026 02:01
@oXtxNt9U
oXtxNt9U marked this pull request as ready for review July 14, 2026 09:50
@oXtxNt9U
oXtxNt9U marked this pull request as draft July 15, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant