Skip to content

fix(crypto-config): add explicit maximum to roundValidators milestone schema #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oXtxNt9U wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(crypto-config): add explicit maximum to roundValidators milestone schema #1410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6663a04
add explicit maximum to roundValidators milestone schema
oXtxNt9U Jul 17, 2026
10dd8fb
test
oXtxNt9U Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/crypto-config/source/configuration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,21 @@ describe<{
);
});

const withRoundValidators = (value: number) => ({
...cryptoJson,
milestones: cryptoJson.milestones.map((milestone, index) =>
index === 1 ? { ...milestone, roundValidators: value } : milestone,
),
});

it("should reject a milestone with roundValidators above the 64 wire-format cap", ({ configManager }) => {
assert.throws(() => configManager.setConfig(withRoundValidators(65)));
});

it("should accept a milestone with roundValidators at the 64 cap", ({ configManager }) => {
assert.not.throws(() => configManager.setConfig(withRoundValidators(64)));
});

it("should throw on set before config is initialized", () => {
const fresh = new Configuration();

Expand Down
5 changes: 4 additions & 1 deletion packages/crypto-config/source/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ const milestone: AnySchemaObject = {
height: { minimum: 0, type: "integer" },
p2p: milestoneP2p,
reward: { type: "string" },
roundValidators: { minimum: 0, type: "integer" },
// Hard ceiling: the consensus wire format packs the signer bitmap into a fixed uint64
// (serializer.ts / validatorSetPack), so index 64 (the 65th validator) overflows on
// serialize. Guard it here until the wire format is redesigned as a variable bitset.
roundValidators: { maximum: 64, minimum: 0, type: "integer" },
satoshi: milestoneSatoshi,
snapshot: milestoneSnapshot,
timeouts: milestoneTimeouts,
Expand Down
Loading