chore: remove dead code and document repository management - #163
Merged
Conversation
- Delete the empty moved.tf left over from a completed state migration - Drop the webhooks["embedded"] lookups; no such webhook is defined, the try() always resolved to an empty map - README: replace the outdated repository type list, document the managed vs seeded file mechanisms, and fill in the 'Adding a new repository' section (including the tf-onboarding team ordering)
Terraform Format and Style 🖌
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup-only PR, no resource changes expected (plan should be empty apart from refresh):
src/moved.tfleft over from a long-completed state migration.try(local.webhooks["embedded"], {})lookups inrepositories_embedded.tfandrepositories_templates.tf— noembeddedwebhook is defined, so the expression always silently resolved to{}. Now it says{}outright.lib-*-rust/svc-*-rustno longer exist) with the actual repository groups, document the managed vs seeded file mechanisms introduced in fix: stop provisioning cspell config #162, and fill in the long-standing 'Adding a new repository' placeholder — including the cross-repo ordering constraint that teams must exist intf-onboardingbefore a repository here can reference them.🤖 Generated with Claude Code