Skip to content

Fix WebAssembly transport timeout crash - #30

Merged
ArthurHeymans merged 2 commits into
masterfrom
fix-wasm-transport-timeout
Sep 16, 2026
Merged

ArthurHeymans merged 2 commits into
masterfrom
fix-wasm-transport-timeout

Conversation

@ArthurHeymans

@ArthurHeymans ArthurHeymans commented Sep 16, 2026

Copy link
Copy Markdown
Owner

The browser tool crashes during its initial protocol read because std::time::Instant is unsupported on wasm32-unknown-unknown.

Use web-time for the shared transport timeout bookkeeping so browser builds use a supported monotonic clock while native behavior remains unchanged.

Pin OSS CAD Suite to the last known working release so unrelated nightly Yosys changes do not break the Verilog CI job.

@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ebe9c33b-15a1-48ac-a447-cabf54c236a6

📥 Commits

Reviewing files that changed from the base of the PR and between d6e5379 and c4458e4.

⛔ Files ignored due to path filters (1)
  • tool/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • tool/Cargo.toml
  • tool/src/device.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The tool adds web-time as a dependency and imports Duration and Instant from web_time in device.rs.

Changes

Tool time API

Layer / File(s) Summary
web-time integration
tool/Cargo.toml, tool/src/device.rs
The tool adds web-time = "1.1" and uses its Duration and Instant types instead of std::time.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to c4458

This change addresses the WASM timing compatibility issue without an established regression or merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing a transport timeout crash on WebAssembly.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-wasm-transport-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ArthurHeymans
ArthurHeymans merged commit fc5dab9 into master Sep 16, 2026
3 checks passed
@ArthurHeymans
ArthurHeymans deleted the fix-wasm-transport-timeout branch September 16, 2026 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant