added MuPDF.NET.LLM #229
Open
added MuPDF.NET.LLM #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-lemon
requested changes
Jan 27, 2026
Contributor
jamie-lemon
left a comment
jamie-lemon
left a comment
There was a problem hiding this comment.
Sorry about this, I think there has to be an overall naming refactor to avoid confusion.
Instead of MuPDF.NET.LLM we need MuPDF.NET4LLM . This is because the stuff is "for use with LLM". We are not writing or integrating an LLM and MuPDF.NET.LLM makes it look like we are.
I hope you can appreciate what I mean here!
We would also need to rename:
MuPDFLLM , MuPDFLLMUtils and anywhere else where it looks like we take about "LLM".
Collaborator
Author
|
I have completed all the renaming tasks. |
jamie-lemon
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.