Stop image prompts from posting a second user bubble

[ArtificialNotImbecile]

What was wrong

Sending a message with image attachments painted the user turn twice: once as the bubble with its thumbnails, then again as a copy carrying the Attached local paths: block and one [Image] line per image. The copy was persisted, so it survived a reload.

Why

Pi stores an image-carrying prompt as a text block plus one content block per image. userTextFromSessionEntry read that entry through the generic content renderer, which renders an image block as [Image], so the entry's text came back as the prompt text plus a placeholder line per image.

The runtime identifies its own prompt among the new session entries by exact text match — sessionEntriesToMessages skips that entry because the caller already has a row for it, and linkCurrentPromptEntry uses the same match to link the message to its Pi entry. With images attached the match never succeeded, so the run emitted its own prompt as a new user turn (live and persisted), and the turn was left without a sessionEntryId, so it could not be branched from.

Fix

Read user entries from their text blocks alone. Attachments already travel on the message row, so the placeholders carried nothing the bubble needed. Assistant and tool-result rendering is untouched.

Test

tests/unit/pi-runtime-equivalence.mjs only ever ran image attachments through the vision-capability rejection path, so nothing reached the identity match with images attached. The new case sends a two-image prompt to a vision-capable mock provider and asserts the persisted rows, the streamed live snapshot, and the prompt link.

Verified red before the fix (['user','assistant'] instead of ['assistant'], and a user role in the live snapshot), green after.

Checks run

• npm run build
• npm run test:unit — all suites pass except pi-remote, which fails on a stale local runtime.tar.gz left over from another branch (its gitignored artifact hash predates main's artifact.json); unrelated to this change and not reproducible on a clean checkout
• npm run harness:check

Full E2E is CI's to confirm.

Also

AGENTS.md no longer routes changes through @codex review; green CI on the head commit is the bar.

🤖 Generated with Claude Code