Revert: restore the re-recognize-taps (live-converge) opt-in#48
Merged
Conversation
AsafMah
force-pushed
the
revert/restore-rerecognize-taps
branch
from
June 6, 2026 09:38
d1c11e6 to
b097724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #47, restoring the
PREF_MULTIPART_RERECOGNIZE_TAPSopt-in (default off) and its machinery.Why: per @SHAWNERZZ on #27, this is intentional Nintype behavior — Nintype reorganizes taps into learned words when a word contains a swipe. The earlier "not unified" objection is actually the missing peck-mode concept (tap-only → literal by design; tap+swipe → converge). Removing it entirely took away a behavior a contributor relies on, so it comes back as an option.
This is a pure
git revertof the #47 squash — restores the pref (5-file),tryLiveConvergeTap,mLiveStroke,getBatchSuggestionsSync, the unit test, and the doc section. Default stays off, so the default experience is unchanged.Planned follow-up (not in this PR): fold this into a 3-way "Tap-after-swipe" mode — Re-recognize (Nintype) / Suggest (B2, #27) / Off — so each user picks. Tracked on #27.
Verified: compiles clean (
compileOfflineDebugJavaWithJavac). It restores the exact tree that existed before #47 (already test-verified), with no intervening changes.