Conversation
…ure lifecycle WordComposer.mExtendBatchInputBase (the multi-part merged-trail base) was only cleared by a normally-completing gesture, so an abnormal end (cancel / empty-top recognition) left it armed, and no deletion path cleared it. A later fresh swipe then merged with the ghost trail - most visibly at the start of a text box. Clear it at the same word-end sites where mLiveStroke is already dropped (handleBackspaceEvent, resetComposingState, commitChosenWord, desync) plus the two gesture-lifecycle origins (onStartBatchInput top, onCancelBatchInput). Does not touch the hot WordComposer.reset() path. Adds 8 tests: base cleared after each backspace mode (character/fragment/whole-word), the delete slider, fresh onStartBatchInput, and onCancelBatchInput; plus 2 guards pinning the (currently dead) static-seed interlock. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…) (#58) * fix(shortcut-row): align down-swipe popup below source key (#36) The below-key (down-swipe) shortcut popup reused the above-key placement formula in PopupKeysKeyboardView.showPopupKeysPanelInternal, compensated by a +container.getMeasuredHeight() hack in MainKeyboardView. That left the bottom popup with the wrong vertical gap/overlap vs the top one. Make the placement below-aware: setShowBelowAnchor() selects a mirrored y-formula that anchors the panel's visible content top to pointY (vs bottom for the above case), and MainKeyboardView passes pointY = key bottom directly. Horizontal anchoring is unchanged (already symmetric). Closes #36. * fix(shortcut-row): align popup icons to the source letter row (#36) The real misalignment was horizontal, not vertical: the popup re-anchored on the swiped key via PopupKeysKeyboard's left/right split, which keys the split off the key's absolute x in the full keyboard. The bottom letter row is inset by the shift key (and bounded by backspace), so the leftmost letter (z) sits well right of x=0 and the icons got placed over the shift area — swiping down on z landed on a middle/right icon instead of the far-left one. The top row starts at x~0 so it looked fine, producing the top/bottom asymmetry. Fix: pin the shortcut popup's visible content left edge to the source letter row's left edge (leftmost normal key), so the 7 icons tile across the row and each letter maps to the icon directly above it (z->1st ... m->7th), draggable sideways. Normal long-press popups are unchanged (NO_ROW_ALIGN sentinel; they still anchor on the key). Verified on-device (S24+).
#40) (#59) C4-ui: when a suggestion is only learned/typed (not in a real dictionary), underline it in the strip and offer Add-to-dictionary / Block on long-press. Adds a per-locale Blocklist settings screen. Backend (DictionaryFacilitator): - addToUserDictionary(word): promote to personal dict + un-blacklist (only once the user dict is resolvable, so we never un-block without adding). - blockWord(word): delegates to removeWord (which already permanently blacklists in every group, incl. history-only words) - gives the UI a clear verb. UI: - SuggestionStripLayoutHelper: underline suggestions whose mSourceDict is USER_HISTORY/USER_TYPED, gated by new pref PREF_FLAG_UNKNOWN_WORDS (default on). - SuggestionStripView: long-press an uncurated word -> AlertDialog (Add/Block/Cancel); curated words keep the existing bin. - BlocklistScreen: per-locale view/remove of blocked words (filesDir/blacklists/*.txt). Test: removeFromBlacklist round-trip (the Add un-block path).
- Fix MiscTest Compose UI tests on CI: add ui-test-manifest to the runTests build type so createComposeRule can resolve ComponentActivity (was debug-only). - Quarantine genuinely env/network-dependent known failures via the existing runTests self-skip (tracked in #12): XLinkTest network link checks, ParserTest backgroundType (Linux-only asset ordering), InputLogicTest tapOnly-gesture-gate and revert-autocorrect (need dictionaries absent in JVM env), StringUtilsTest emoji-data test. - Remove continue-on-error so a real test failure now fails the job.
fix(two-thumb): clear stale merged-trail extend-base on delete + gesture lifecycle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
dev→mainfor the LeanTypeDual 3.8.6 release. versionName 3.8.6 / versionCode 3860.What ships (since 3.8.5)
All four feature PRs were merged to
dev, CI is green ondev, and every user-facing change was confirmed on-device. After merge: add the signing secrets, then push tagv3.8.6to trigger the signed build + draft release.