fix(shortcut-row): tile popup icons proportionally across the usable row (#36)#68
Merged
Merged
Conversation
…row (#36) Follow-up to #58: the left-pin used natural icon width, so N icons tiled from the left and the far-right keys couldn't reach them. Now each icon is sized to rowWidth/iconCount (usable normal-key row span), so the N icons tile the whole row and a swipe maps proportionally — swiping from the i-th 1/N of the row selects the i-th icon. Threads a fixedKeyWidth into PopupKeysKeyboard.Builder (0 = default for normal/emoji popups); dividers are dropped in that mode so the icons tile exactly.
Owner
Author
|
On-device verified (S24+): icons now tile the usable letter-row proportionally — far-left key hits the far-left icon, far-right key the far-right icon. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the merged #58. On-device, the left-pin aligned the icons to the left at natural width, so the far-right keys couldn't reach the popup. Now the N icons are each sized to rowWidth/iconCount (the usable normal-key row span) and pinned to the row's left edge, so they tile the whole row and a swipe maps proportionally — swiping from the i-th 1/N segment of the usable row selects the i-th icon. Threads a
fixedKeyWidththroughPopupKeysKeyboard.Builder(0 = default for normal/emoji long-press popups; dividers dropped in that mode so icons tile exactly). Compiles; needs on-device confirmation of the proportional feel.