-
Notifications
You must be signed in to change notification settings - Fork 26
[refactor] Simplify initialization and improve API usability #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a2f70f1
simplify init & interface
0oshowero0 2798354
fix pre-commit
0oshowero0 5eb6d70
fix pre-commit
0oshowero0 512e659
fix ut
0oshowero0 5d6146e
fix
0oshowero0 812e55f
fix
0oshowero0 3365f30
fix
0oshowero0 3fd78d2
fix race condition
0oshowero0 5d51de3
fix typo
0oshowero0 1346318
simplify storage manager init
0oshowero0 fecb07d
fix
0oshowero0 9217ca3
fix minor comments
0oshowero0 23ab1ae
fix comments
0oshowero0 4f0d3f8
fix
0oshowero0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,4 +4,5 @@ pyzmq | |
| hydra-core | ||
| numpy<2.0.0 | ||
| msgspec | ||
| psutil | ||
| psutil | ||
| omegaconf | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # This is the default configuration of TransferQueue. Users may modify the default value | ||
| # and use transfer_queue.init(conf) to overwrite the config entries. | ||
|
|
||
| controller: | ||
| # User-defined sampler. User can pass sampler instance to overwrite this string config. | ||
| sampler: SequentialSampler | ||
| # Whether return an empty BatchMeta to prevent request blocking when no enough data is available | ||
| polling_mode: False | ||
| # ZMQ Server IP & Ports (automatically generated during init) | ||
| zmq_info: null | ||
|
|
||
|
|
||
| backend: | ||
| # Pluggable storage/transport backend of TransferQueue. Choose from: | ||
| # SimpleStorage, Yuanrong, MooncakeStore, ... | ||
| storage_backend: SimpleStorage | ||
|
|
||
| # For SimpleStorage: | ||
| SimpleStorage: | ||
| # Total number of samples | ||
| total_storage_size: 100000 | ||
| # Number of distributed storage units for SimpleStorage backend | ||
| num_data_storage_units: 2 | ||
| # ZMQ Server IP & Ports (automatically generated during init) | ||
| zmq_info: null | ||
|
|
||
| # For Yuanrong: | ||
| # TODO | ||
|
|
||
| # For MooncakeStore: | ||
| # TODO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.