Skip to content

[misc] refactor: simplify internal classes naming#86

Merged
ji-huazhong merged 3 commits into
Ascend:mainfrom
ji-huazhong:refactor
May 2, 2026
Merged

[misc] refactor: simplify internal classes naming#86
ji-huazhong merged 3 commits into
Ascend:mainfrom
ji-huazhong:refactor

Conversation

@0lynnlin0
Copy link
Copy Markdown
Contributor

@0lynnlin0 0lynnlin0 commented May 2, 2026

Rename internal classes by removing TransferQueue prefix:

  • TransferQueueStorageManager → StorageManager
  • TransferQueueStorageManagerFactory → StorageManagerFactory
  • StorageClientFactory → StorageKVClientFactory
  • TransferQueueRole → Role
  • move the factory class to base.py
  • rename simple_backend.py to simple_storage.py

These classes are internal components not exposed as public API, so the shorter names improve readability without causing conflicts.

Besides, enable modern type annotation style:
Auto convert legacy Optional/Union type annotations to modern X | None syntax.

cc @0oshowero0

Signed-off-by: ji-huazhong <hzji210@gmail.com>
@ascend-robot
Copy link
Copy Markdown

CLA Signature Pass

0lynnlin0, thanks for your pull request. All authors of the commits have signed the CLA. 👍

…onal/Union → X | None)

Signed-off-by: ji-huazhong <hzji210@gmail.com>
@ascend-robot
Copy link
Copy Markdown

CLA Signature Pass

ji-huazhong, thanks for your pull request. All authors of the commits have signed the CLA. 👍

1 similar comment
@ascend-robot
Copy link
Copy Markdown

CLA Signature Pass

ji-huazhong, thanks for your pull request. All authors of the commits have signed the CLA. 👍

@ascend-robot
Copy link
Copy Markdown

CLA Signature Pass

ji-huazhong, thanks for your pull request. All authors of the commits have signed the CLA. 👍

@ascend-robot
Copy link
Copy Markdown

CLA Signature Pass

ji-huazhong, thanks for your pull request. All authors of the commits have signed the CLA. 👍

@ascend-robot
Copy link
Copy Markdown

CLA Signature Pass

ji-huazhong, thanks for your pull request. All authors of the commits have signed the CLA. 👍

@ascend-robot
Copy link
Copy Markdown

CLA Signature Pass

ji-huazhong, thanks for your pull request. All authors of the commits have signed the CLA. 👍

@ascend-robot
Copy link
Copy Markdown

CLA Signature Pass

ji-huazhong, thanks for your pull request. All authors of the commits have signed the CLA. 👍

@ascend-robot
Copy link
Copy Markdown

CLA Signature Pass

ji-huazhong, thanks for your pull request. All authors of the commits have signed the CLA. 👍

@ascend-robot
Copy link
Copy Markdown

CLA Signature Pass

ji-huazhong, thanks for your pull request. All authors of the commits have signed the CLA. 👍

Signed-off-by: ji-huazhong <hzji210@gmail.com>
@ascend-robot
Copy link
Copy Markdown

CLA Signature Pass

ji-huazhong, thanks for your pull request. All authors of the commits have signed the CLA. 👍

@ji-huazhong ji-huazhong merged commit 05eb2aa into Ascend:main May 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants