feat: Add native support for inserting editable and responsive tables (#21)#29
Open
Rishabh1925 wants to merge 2 commits into
Open
feat: Add native support for inserting editable and responsive tables (#21)#29Rishabh1925 wants to merge 2 commits into
Rishabh1925 wants to merge 2 commits into
Conversation
Updated Favicon and Title
Author
|
Hi @Ashish94312, I've submitted PR #21 which adds table support. |
Owner
|
@Rishabh1925 can you check again its not working ig, or it's good if you share demo video. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21
Summary: This PR introduces support for inserting tables into the editor, complete with basic structural controls and responsive handling for mobile viewports.
Key Implementation Details:
Insert Groupof the editor toolbar (EditorToolbar.jsx).insertTablecommand inuseEditor(Editor.jsx).document.execCommand('insertHTML')to inject a static HTML table structure wrapped in a<div contenteditable='false'>container. This prevents the rich text editor (which relies ondocument.execCommand) from corrupting the table's internal DOM structure, ensuring the table remains functional and stable within the editor.TableComponent.jsx): Provides a basic 3x3 table with inline styles for visibility.min-width: 600pxand is wrapped in a container withoverflow-x: autoto ensure the table scrolls horizontally on mobile devices without causing the main document page to overflow.Ready for Review.