Skip to content

fix: improve toast notification visibility in dark mode #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Akshat-Neeraj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improve toast notification visibility in dark mode #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions client/src/components/NotificationDropdown.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ const NotificationDropdown = () => {
animate={{ opacity: 1, y: 0, scale: 1 }}
exit={{ opacity: 0, y: -10, scale: 0.95 }}
transition={{ duration: 0.2 }}
className="absolute right-0 mt-2 w-80 bg-white dark:bg-navy-800 rounded-lg shadow-lg border border-navy-200 dark:border-navy-700 z-50"
className="absolute right-0 mt-2 w-80 overflow-hidden rounded-xl border border-navy-200 dark:border-navy-700 bg-white dark:bg-navy-800 shadow-2xl z-50"
>
{/* Header */}
<div className="flex items-center justify-between p-4 border-b border-navy-200 dark:border-navy-700">
Expand Down Expand Up @@ -198,14 +198,16 @@ const NotificationDropdown = () => {
) : (
notifications.map((notification) => (
<motion.div
key={notification._id}
initial={{ opacity: 0, x: -20 }}
animate={{ opacity: 1, x: 0 }}
className={`p-4 border-b border-navy-100 dark:border-navy-700 cursor-pointer hover:bg-navy-50 dark:hover:bg-navy-700/50 transition-colors ${
!notification.read ? 'bg-blue-50 dark:bg-blue-900/20' : ''
}`}
onClick={() => handleNotificationClick(notification)}
>
key={notification._id}
initial={{ opacity: 0, x: -20 }}
animate={{ opacity: 1, x: 0 }}
className={`group p-4 border-b border-navy-100 dark:border-navy-700 cursor-pointer hover:bg-navy-50 dark:hover:bg-navy-700/50 transition-colors ${
!notification.read
? 'bg-blue-50 dark:bg-blue-900/30 border-l-4 border-blue-500'
: ''
}`}
onClick={() => handleNotificationClick(notification)}
>
<div className="flex items-start space-x-3">
<div className="flex-shrink-0 mt-1">
{getNotificationIcon(notification.type)}
Expand All @@ -216,7 +218,7 @@ const NotificationDropdown = () => {
{notification.sender?.username || 'Unknown User'}
</p>
<div className="flex items-center space-x-1">
<span className="text-xs text-navy-500 dark:text-navy-400">
<span className="text-xs text-navy-600 dark:text-navy-300">
{formatTimeAgo(notification.createdAt)}
</span>
<button
Expand All @@ -227,7 +229,7 @@ const NotificationDropdown = () => {
</button>
</div>
</div>
<p className="text-sm text-navy-600 dark:text-navy-300 mt-1">
<p className="mt-1 text-sm text-navy-700 dark:text-navy-200">
{notification.content}
</p>
{!notification.read && (
Expand Down