fix: sort top questions by upvote count#64
Open
saurabhhhcodes wants to merge 1 commit into
Open
Conversation
|
Someone is attempting to deploy a commit to the anglenobida003-8112's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sort=votespath sort by computed upvote countvotes.upvotesvoter objectsRoot Cause
The route previously sorted
Topquestions with{ 'votes.upvotes': -1 }.votes.upvotesis an array of vote objects, so MongoDB sorts by array element values instead of the number of votes. That can rank a one-vote question above a higher-voted question depending on voter ObjectIds.Changes Made
buildTopQuestionsPipeline()to computeupvoteCountForSortusing$sizesort=votes; other sort modes keep the existingfind().sort()behaviorTesting
npm cinpm test -- --runTestsByPath tests/question-query-service.test.jsnode --check server/routes/questions.js && node --check server/services/questionQueries.js && node --check tests/question-query-service.test.jsgit diff --checkNote
npm cicompleted with existing dependency audit/deprecation warnings. This PR does not change dependency files.Fixes #57