Skip to content

Property val fix #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbomDocPhibes wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Property val fix #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f3921a8
propvalue fix
AbomDocPhibes Oct 9, 2025
546de36
Update changelog.md
AbomDocPhibes Oct 9, 2025
0218690
syntax fix
AbomDocPhibes Oct 9, 2025
fc6e4b5
propvalue workaround
AbomDocPhibes Mar 17, 2026
6c57911
Update changelog.md
AbomDocPhibes Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified bin/ImageLightbox.adc
View file
Open in desktop
Binary file not shown.
7 changes: 2 additions & 5 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
Version 1.0.0

- Feature 1
- Feature 2

Version 4.0.1
Version 4.0.2

- changed PropValue syntax with .Var for id="path"
- changed property type for image selection from "file" to "string" to fix issue with image path not being properly returned
9 changes: 3 additions & 6 deletions config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,9 @@
<info>
<name>ImageLightbox</name>
<guid>c9141526-1cff-4825-827f-a44615d33567</guid>
<version>4.0.1</version>
<version>4.0.2</version>
<date>2016-06-07</date>
<description><![CDATA[Image Lightbox
v2.0.2 - Add alt attribute to img
v2.0.3 - Fixed Issue in simplbox.js
v4.0.0 - implement file type parameter]]></description>
<description><![CDATA[]]></description>
<company>Askia</company>
<author><![CDATA[Jérôme Duparc <jeromed@askia.com>]]></author>
<site>http://www.askia.com</site>
Expand Down Expand Up @@ -47,7 +44,7 @@
</outputs>
<properties>
<category id="General" name="General">
<property xsi:type="standardProperty" id="path" name="Path of the image" type="file" mode="dynamic" require="true" visible="true">
<property xsi:type="standardProperty" id="path" name="Path of the image" type="string" mode="dynamic" require="true" visible="true">
<description><![CDATA[Path of the image]]></description>
<value></value>
</property>
Expand Down
2 changes: 1 addition & 1 deletion resources/dynamic/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@
</script>

<div id="adc_{%= CurrentADC.InstanceId %}" class="adc-imagelightbox">
<a href="{%:= CurrentADC.Var("path") %}" target="_blank" data-simplbox="adc_{%= CurrentADC.InstanceId %}"><img src="{%:= CurrentADC.Var("path") %}" /></a>
<a href="{%:= CurrentADC.PropValue("path") %}" target="_blank" data-simplbox="adc_{%= CurrentADC.InstanceId %}"><img src="{%:= CurrentADC.PropValue("path") %}" /></a>
</div>
Loading